Obviously I am a supporter the free software movement and free software itself. My main criticism is its failure to fully articulate the thing it was actually advocating, namely the idea that software should be a social good rather than a capitalist commodity.
That it should miss this implication is not surprising given that the movement itself arose during the Cold War, and you couldn't go around giving people the impression that you were some kind of communist in Reagan's America.
But at its core, software as something that served the public, rather than the whims and priorities of companies and corporations, is at the very heart of the argument. This de-commodification is essential for the sharing of source code and further implies that software development should be supported by public resources. The "Public Money - Public Code" movement in Europe seems a logical expression of this implication.
Freedom is not a consumer choice, but a state of being. The FSF's campaigns implore users to "choose freedom," without a coherent analysis of the sentiment. You do not pull freedom off of a shelf like a commodity.